Add Flag to PeftLoraLoaderMixinTests to Enable/Disable Text Encoder LoRA Tests
#12962
+67
−304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
Jan 12, 2026
| is_correct_format = all("lora" in key for key in state_dict.keys()) | ||
| if not is_correct_format: | ||
| raise ValueError("Invalid LoRA checkpoint.") | ||
| raise ValueError("Invalid LoRA checkpoint. Make sure all LoRA param names contain `lora`.") |
Member
There was a problem hiding this comment.
Suggested change
| raise ValueError("Invalid LoRA checkpoint. Make sure all LoRA param names contain `lora`.") | |
| raise ValueError("Invalid LoRA checkpoint. Make sure all LoRA param names contain `"lora"` substring.") |
Collaborator
Author
|
Merging as the failing LoRA tests should be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
supports_text_encoder_lorasflag toPeftLoraLoaderMixinTests, which if set toFalsewill skip the following text encoder LoRA tests (following #12933):test_simple_inference_with_text_loratest_simple_inference_with_text_lora_and_scaletest_simple_inference_with_text_lora_fusedtest_simple_inference_with_text_lora_save_loadtest_simple_inference_with_partial_text_loratest_simple_inference_save_pretrained_with_text_lorasupport_text_encoder_lorasis then used in thePeftLoraLoaderMixinTestssubclasses to skip these tests for LoRA loaders which don't support text encoder LoRAs. Note that previously most test classes did not skiptest_simple_inference_save_pretrained_with_text_lora, which means that this test will now be skipped instead of running and passing as it did previously.This PR also makes the following changes to
LoraBaseMixinsubclasses (from #12933 (comment)):load_lora_weights, makes the invalid LoRA format error message more informative by describing the valid checkpoint format.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul